added timout for gemini

app.py

@@ -73,21 +73,18 @@ def generate_certificate_image(name_on_cert):
 
         if not os.path.exists(certificate_template_path):
             alt_cert_path_templates_parent = os.path.join(current_dir,"..", "templates", "certificate.png")
-            alt_cert_path_root = os.path.join(current_dir, "certificate.png") # This is the same as initial
+            alt_cert_path_root = os.path.join(current_dir, "certificate.png") 
             
             if os.path.exists(alt_cert_path_templates_parent):
                  certificate_template_path = alt_cert_path_templates_parent
-            # The next elif is redundant if the initial check for certificate_template_path (which is alt_cert_path_root) failed.
-            # However, to keep it identical to the user's provided version:
             elif os.path.exists(alt_cert_path_root):
                  certificate_template_path = alt_cert_path_root
             else:
-                # The error message in the user's version was slightly different, I'll use a combined one.
                 raise FileNotFoundError(f"Certificate template not found. Checked default, ../templates/, and root relative to app.py.")
 
         if not os.path.exists(font_path):
             alt_font_path_parent = os.path.join(current_dir, "..","Quattrocento-Regular.ttf")
-            alt_font_path_root = os.path.join(current_dir, "Quattrocento-Regular.ttf") # Same as initial
+            alt_font_path_root = os.path.join(current_dir, "Quattrocento-Regular.ttf") 
 
             if os.path.exists(alt_font_path_parent):
                  font_path = alt_font_path_parent
@@ -144,7 +141,8 @@ def get_gaia_api_questions():
     try:
         questions_url = f"{GAIA_API_BASE_URL}/questions"
         print(f"Attempting to fetch questions from: {questions_url}")
-        response = requests.get(questions_url)
+        # Adding a timeout to the GET request as well, for consistency
+        response = requests.get(questions_url, timeout=30) # 30-second timeout for fetching questions
         response.raise_for_status() 
         return response.json(), None 
     except requests.exceptions.RequestException as e:
@@ -162,14 +160,11 @@ def my_agent_logic(task_id: str, question: str, files: list = None):
     if files:
         print(f"Files associated with this task: {files}")
 
-    # IMPORTANT: You MUST set GEMINI_API_KEY as a Space Secret for this to work.
     gemini_api_key = os.environ.get("GEMINI_API_KEY")
     if not gemini_api_key:
         print("Error: GEMINI_API_KEY not found in environment variables. Please set it in Space Secrets.")
         return f"ERROR_GEMINI_KEY_MISSING_FOR_TASK_{task_id}"
 
-    # Construct the prompt for Gemini
-    # This prompt is crucial. You will likely need to refine it.
     prompt_parts = [
         "You are an AI assistant answering questions for the GAIA benchmark.",
         "Your goal is to provide the single, exact, concise, and factual answer to the question below.",
@@ -189,21 +184,23 @@ def my_agent_logic(task_id: str, question: str, files: list = None):
             "role": "user",
             "parts": [{"text": full_prompt}]
         }],
-        "generationConfig": { # Optional: You can configure temperature, topK, topP etc.
-            "temperature": 0.4, # Lower temperature for more factual/deterministic answers
+        "generationConfig": { 
+            "temperature": 0.4, 
             "maxOutputTokens": 250,
         }
     }
 
     api_url_with_key = f"{GEMINI_API_URL_BASE}?key={gemini_api_key}"
     
-    agent_computed_answer = f"ERROR_CALLING_GEMINI_FOR_TASK_{task_id}" # Default in case of error
+    agent_computed_answer = f"ERROR_CALLING_GEMINI_FOR_TASK_{task_id}" 
 
     try:
         headers = {"Content-Type": "application/json"}
         print(f"Calling Gemini API for task {task_id}...")
-        response = requests.post(api_url_with_key, headers=headers, json=payload, timeout=60) # Added timeout
-        response.raise_for_status()  # Raise an exception for HTTP errors
+        # --- MODIFIED LINE: Added timeout=60 ---
+        response = requests.post(api_url_with_key, headers=headers, json=payload, timeout=60) 
+        # --- END OF MODIFIED LINE ---
+        response.raise_for_status()  
         
         result = response.json()
         
@@ -212,12 +209,10 @@ def my_agent_logic(task_id: str, question: str, files: list = None):
             result["candidates"][0]["content"].get("parts") and
             result["candidates"][0]["content"]["parts"][0].get("text")):
             agent_computed_answer = result["candidates"][0]["content"]["parts"][0]["text"].strip()
-            # Post-processing: remove any accidental "FINAL ANSWER:" prefix if LLM still adds it.
             if agent_computed_answer.upper().startswith("FINAL ANSWER:"):
                 agent_computed_answer = agent_computed_answer[len("FINAL ANSWER:"):].strip()
         else:
             print(f"Warning: Unexpected response structure from Gemini API for task {task_id}: {result}")
-            # Check for promptFeedback if a candidate is missing
             if result.get("promptFeedback") and result["promptFeedback"].get("blockReason"):
                 block_reason = result["promptFeedback"]["blockReason"]
                 print(f"Gemini API blocked the prompt for task {task_id}. Reason: {block_reason}")
@@ -225,6 +220,9 @@ def my_agent_logic(task_id: str, question: str, files: list = None):
             else:
                 agent_computed_answer = f"ERROR_PARSING_GEMINI_RESPONSE_FOR_TASK_{task_id}"
 
+    except requests.exceptions.Timeout:
+        print(f"Timeout error calling Gemini API for task {task_id}.")
+        agent_computed_answer = f"ERROR_GEMINI_TIMEOUT_FOR_TASK_{task_id}"
     except requests.exceptions.RequestException as e:
         print(f"Error calling Gemini API for task {task_id}: {e}")
         if e.response is not None:
@@ -288,16 +286,14 @@ def submit_agent_answers(profile: gr.OAuthProfile, answers_for_submission_state)
     if not answers_for_submission_state:
         return "No answers available to submit. Please run the agent first."
     username = profile.username
-    space_id = os.getenv('SPACE_ID', '') # Expected format: "username/spacename"
+    space_id = os.getenv('SPACE_ID', '') 
     agent_code_link = f"https://huggingface.co/spaces/{space_id}/tree/main"
-    # Add a temporary log message list for this function
     submission_log_messages = [f"Preparing to submit answers for user: {username}"]
 
     if not space_id:
-        # Fallback if SPACE_ID is not available
         your_space_name_guess = os.path.basename(os.path.dirname(os.path.abspath(__file__)))
         if not your_space_name_guess or your_space_name_guess == 'app':
-             your_space_name_guess = "YOUR_SPACE_NAME_HERE" # Default placeholder
+             your_space_name_guess = "YOUR_SPACE_NAME_HERE" 
         agent_code_link = f"https://huggingface.co/spaces/{username}/{your_space_name_guess}/tree/main"
         submission_log_messages.append(f"Warning: SPACE_ID not found. Constructed agent_code_link as: {agent_code_link}. Please verify this link is correct.")
     
@@ -308,12 +304,12 @@ def submit_agent_answers(profile: gr.OAuthProfile, answers_for_submission_state)
         "agent_code": agent_code_link,
         "answers": answers_for_submission_state 
     }
-    # submission_log_messages.append(f"Payload (shortened answers): {{'username': '{username}', 'agent_code': '{agent_code_link}', 'answers_count': {len(answers_for_submission_state)}}}")
 
     try:
         submit_url = f"{GAIA_API_BASE_URL}/submit"
-        print(f"Attempting to submit answers to: {submit_url} with payload: {payload}") # Keep for server logs
-        response = requests.post(submit_url, json=payload, timeout=60) # Added timeout
+        print(f"Attempting to submit answers to: {submit_url} with payload: {payload}") 
+        # Adding a timeout to the POST request for submission as well
+        response = requests.post(submit_url, json=payload, timeout=60) 
         response.raise_for_status()
         submission_response = response.json()
         submission_log_messages.append(f"Submission successful! Response: {submission_response}")
@@ -325,6 +321,10 @@ def submit_agent_answers(profile: gr.OAuthProfile, answers_for_submission_state)
         elif score_string: final_message = score_string
         elif score is not None: final_message = f"Score: {score}"
         return "\n".join(submission_log_messages) + f"\n\n➡️ Result: {final_message}"
+    except requests.exceptions.Timeout:
+        error_detail = f"Timeout error submitting answers to GAIA scoring API."
+        submission_log_messages.append(error_detail)
+        return "\n".join(submission_log_messages)
     except requests.exceptions.RequestException as e:
         error_detail = f"Error submitting answers: {e}"
         if e.response is not None: