Update app.py

app.py

@@ -10,79 +10,102 @@ GROQ_API_KEY = "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"
 st.title('🎯 AI Quiz Generator')
 st.subheader('🚀 Test Your Knowledge!')
 
-# User Inputs
+# Input Fields
 standard = st.text_input('📚 Enter Standard/Grade')
 topic = st.text_input('📝 Enter Topic')
+
+# Quiz Type Selection
 quiz_type = st.selectbox("🎭 Select Quiz Type", ["Multiple Choice Questions (MCQ)", "True or False", "Fill in the Blanks"])
+
+# Difficulty Level Selection
 difficulty = st.radio("📊 Select Difficulty Level", ["Low", "Medium", "Hard"])
+
+# Number of Questions Selection (1 to 10)
 num_questions = st.slider("🔢 Select Number of Questions", min_value=1, max_value=10, value=5)
 
 # Initialize AI Model
 model = ChatGroq(
     temperature=0.6,
     groq_api_key=GROQ_API_KEY,
-    model_name="llama-3.3-70b-versatile"
+    model_name="llama-3.3-70b-versatile" 
 )
 
 def generate_quiz(standard, topic, quiz_type, difficulty, num_questions):
-    """Generate quiz questions dynamically based on user selection."""
-
+    """Generate quiz based on user selection and return JSON data."""
+    
     if quiz_type == "Multiple Choice Questions (MCQ)":
         prompt = f"""
         Generate {num_questions} multiple choice questions (MCQs) for a {standard} student on {topic}. 
         Each question should have exactly 4 options (A, B, C, D) and one correct answer.
-        Return the result in this format:
-        
-        1. Question text?
-        A) Option 1
-        B) Option 2
-        C) Option 3
-        D) Option 4
-        
-        Answer: Correct Option (A, B, C, or D)
+        Return the result strictly in the following JSON format:
+        {{
+            "questions": [
+                {{"question": "Question text", "options": ["A) Option 1", "B) Option 2", "C) Option 3", "D) Option 4"], "answer": "A) Option"}}
+            ]
+        }}
         """
     elif quiz_type == "True or False":
         prompt = f"""
         Generate {num_questions} True or False questions for a {standard} student on {topic}.
-        Return the result in this format:
-
-        1. Question text?
-        Answer: True or False
+        Return the result in strict JSON format:
+        {{
+            "questions": [
+                {{"question": "Question text", "answer": "True or False"}}
+            ]
+        }}
         """
     else:  # Fill in the Blanks
         prompt = f"""
         Generate {num_questions} fill-in-the-blank questions for a {standard} student on {topic}.
-        Return the result in this format:
-
-        1. The capital of France is __.
-        Answer: Paris
+        Provide correct answers in JSON format:
+        {{
+            "questions": [
+                {{"question": "Question with __ blank", "answer": "Correct Answer"}}
+            ]
+        }}
         """
 
     try:
         response = model.predict(prompt).strip()  # Ensure clean output
-        quiz_lines = response.split("\n")  # Split response into lines
-        questions = []
-        current_question = None
-
-        for line in quiz_lines:
-            if line.strip() and not line.startswith("Answer:"):
-                if line[0].isdigit():  # New question detected
-                    if current_question:
-                        questions.append(current_question)
-                    current_question = {"question": line, "options": [], "answer": ""}
-                elif line[0] in "ABCD)" and quiz_type == "Multiple Choice Questions (MCQ)":
-                    current_question["options"].append(line)
-            elif line.startswith("Answer:"):
-                current_question["answer"] = line.split("Answer: ")[1]
-
-        if current_question:
-            questions.append(current_question)
-
-        return questions
+
+        # Validate if response is in JSON format
+        quiz_data = json.loads(response)
+        if "questions" in quiz_data:
+            return quiz_data
+        else:
+            st.error("⚠️ The AI did not return a valid quiz format.")
+            return None
+    except json.JSONDecodeError:
+        st.error("⚠️ Failed to generate quiz. The AI did not return a proper JSON response.")
+        return None
     except Exception as e:
-        st.error(f"⚠️ Failed to generate quiz. Error: {str(e)}")
+        st.error(f"⚠️ Error: {str(e)}")
         return None
 
+
+def normalize_answer(answer):
+    """Convert answers to a standard format for comparison."""
+    answer = answer.strip().lower()
+    if ") " in answer:  # Handles cases like "A) Football"
+        answer = answer.split(") ")[0]  # Keep only "A", "B", etc.
+    return answer
+
+def calculate_score(user_answers, correct_answers):
+    """Calculate score and return details of correct and incorrect answers."""
+    results = []
+    score = 0
+
+    for q, user_ans in user_answers.items():
+        correct_ans = normalize_answer(correct_answers.get(q, ""))
+        user_ans = normalize_answer(user_ans)
+
+        is_correct = user_ans == correct_ans
+        results.append((q, user_ans, correct_ans, is_correct))
+        if is_correct:
+            score += 1
+
+    return score, results
+
 # Session state to store quiz data
 if 'quiz_data' not in st.session_state:
     st.session_state.quiz_data = None
@@ -96,52 +119,54 @@ if st.button("🚀 Generate Quiz"):
         if st.session_state.quiz_data:
             st.session_state.user_answers = {}  # Reset answers
             st.success(f"{quiz_type} Quiz Generated with {num_questions} Questions! 🎉")
+            st.balloons()  # 🎈 Balloons for generating the quiz
     else:
         st.error("⚠️ Please enter both the standard and topic.")
 
 # Display Quiz if Available
 if st.session_state.quiz_data:
     st.write("### 📝 Quiz Questions:")
-    for i, q in enumerate(st.session_state.quiz_data):
+    questions = st.session_state.quiz_data.get("questions", [])
+
+    for i, q in enumerate(questions):  # Display all selected questions
         st.write(f"**Q{i+1}: {q['question']}**")
 
         if quiz_type == "Multiple Choice Questions (MCQ)":
-            user_answer = st.radio(f"🧐 Select your answer for Q{i+1}", options=q["options"], key=f"question_{i+1}")
+            user_answer = st.radio(f"🧐 Select your answer for Question {i+1}", options=q["options"], key=f"question_{i+1}")
         elif quiz_type == "True or False":
-            user_answer = st.radio(f"🧐 Select your answer for Q{i+1}", options=["True", "False"], key=f"question_{i+1}")
+            user_answer = st.radio(f"🧐 Select your answer for Question {i+1}", options=["True", "False"], key=f"question_{i+1}")
         else:  # Fill in the Blanks
-            user_answer = st.text_input(f"🧐 Your answer for Q{i+1}", key=f"question_{i+1}")
+            user_answer = st.text_input(f"🧐 Your answer for Question {i+1}", key=f"question_{i+1}")
 
         st.session_state.user_answers[f"question_{i+1}"] = user_answer
 
 # Submit Quiz Button
 if st.button("✅ Submit Quiz"):
     if st.session_state.quiz_data:
-        correct_answers = {f"question_{i+1}": q["answer"].strip().lower() for i, q in enumerate(st.session_state.quiz_data)}
-        score = sum(1 for q_id, user_ans in st.session_state.user_answers.items() 
-            if user_ans.strip().lower() == correct_answers.get(q_id, ""))
-
+        correct_answers = {f"question_{i+1}": q["answer"].strip().lower() for i, q in enumerate(st.session_state.quiz_data["questions"])}
+        score, results = calculate_score(st.session_state.user_answers, correct_answers)
 
         st.write("### 🎯 Quiz Results")
         st.write(f"Your Score: **{score}/{num_questions}** 🎉")
 
-        # Show correct & incorrect answers
-        for q_id, user_ans in st.session_state.user_answers.items():
-            correct_ans = correct_answers.get(q_id, "")
-            if user_ans == correct_ans:
-                st.success(f"✅ {q_id.replace('_', ' ').title()} - Correct! ({correct_ans})")
+        # Display Correct Answers
+        for q_id, user_ans, correct_ans, is_correct in results:
+            question_num = q_id.replace("question_", "Question ")
+            if is_correct:
+                st.success(f"✅ {question_num} - Correct! ({correct_ans.upper()})")
             else:
-                st.error(f"❌ {q_id.replace('_', ' ').title()} - Incorrect! Your Answer: {user_ans} | Correct Answer: {correct_ans}")
+                st.error(f"❌ {question_num} - Incorrect! Your Answer: {user_ans.upper()} | Correct Answer: {correct_ans.upper()}")
 
         # 🎉 Animations based on score
-        time.sleep(1)
+        time.sleep(1)  # Small delay for better effect
         if score == num_questions:
-            st.snow()  # 🎉 Perfect score effect
-            st.success("🏆 Perfect Score! You're a genius! 🚀")
+            st.snow()  # 🏆 Trophy effect for a perfect score
+            st.success("🏆 Perfect Score! You are a genius! 🚀")
         elif score / num_questions >= 0.7:
-            st.success("🎉 Great job! Keep practicing! 💪")
+            st.success("🎉 Great job! Keep practicing!")
         else:
             st.warning("😃 Don't worry! Learn from mistakes and try again! 📚")
 
     else:
         st.error("⚠️ Quiz data not available. Please regenerate the quiz.")
+